init: don't suggest -reindex-chainstate for recovery on a pruned node #35849

pull kwsantiago wants to merge 1 commits into bitcoin:master from privkeyio:fix-prune-reindex-chainstate-suggestion changing 1 files +1 −1
  1. kwsantiago commented at 4:00 PM on July 30, 2026: contributor

    When chainstate loading fails, init offers to rebuild the databases and, if declined, suggests restarting with -reindex or -reindex-chainstate.

    On a pruned node -reindex-chainstate cannot recover: it rebuilds the chainstate by replaying existing block data, which has been pruned, and the node already rejects it with "Prune mode is incompatible with -reindex-chainstate. Use full -reindex instead." Only a full -reindex recovers a pruned node.

    Omit -reindex-chainstate from the suggestion when pruning is enabled.

  2. DrahtBot commented at 4:00 PM on July 30, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35849.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK sedited, alexanderwiederin

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. DrahtBot added the label Needs rebase on Jul 30, 2026
  4. kwsantiago force-pushed on Jul 30, 2026
  5. init: don't suggest -reindex-chainstate for recovery on a pruned node adbff4d442
  6. kwsantiago force-pushed on Jul 30, 2026
  7. DrahtBot added the label CI failed on Jul 30, 2026
  8. DrahtBot removed the label CI failed on Jul 30, 2026
  9. DrahtBot removed the label Needs rebase on Jul 30, 2026
  10. sedited approved
  11. sedited commented at 8:44 AM on September 11, 2026: contributor

    ACK adbff4d442864061171c693d6f57b51c9d8180c8

  12. alexanderwiederin commented at 9:37 AM on September 11, 2026: contributor

    ACK adbff4d442864061171c693d6f57b51c9d8180c8

  13. sedited merged this on Sep 14, 2026
  14. sedited closed this on Sep 14, 2026

  15. jonatack commented at 5:39 PM on September 14, 2026: member

    Post-merge ACK, prune mode is incompatible with -reindex-chainstate.

  16. kwsantiago deleted the branch on Sep 14, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-21 00:52 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me