There is no reason we should process conflicting advertisements for transactions, as they cannot be both accepted into our mempool.
Avoid processing these and doing spurious work.
Should be no change in observable behavior.
net_processing: process unique tx INVs only #35878
pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2026-07-inv_dedup changing 2 files +45 −0-
instagibbs commented at 12:17 PM on August 4, 2026: member
-
b11d8fc5f7
net_processing: process unique tx INVs only
There is no reason we should process conflicting advertisements for transactions, as they cannot be both accepted into our mempool. Avoid processing these and doing spurious work.
-
DrahtBot commented at 12:17 PM on August 4, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35878.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #35351 (net: Disallow invalid HeadersSyncState due to lagging clock by hodlinator)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fjahr commented at 3:13 PM on August 4, 2026: contributor
Concept ACK
-
darosior commented at 5:04 PM on August 4, 2026: member
Makes sense. Concept ACK.
-
yuvicc commented at 5:23 AM on August 5, 2026: contributor
Concept ACK
Deduplicating identical tx announcements makes sense.
Contributors