ci: Fix $BASE_ROOT_DIR installation #35879

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2608-ci-fix-install changing 3 files +8 −6
  1. maflcko commented at 1:17 PM on August 4, 2026: member

    In the ci system, BASE_ROOT_DIR has a default value that can be changed. This has problems:

    • The docs do not mention that changing the value requires re-building the image, as the value is embedded.
    • Many places hard-code the default value, which is confusing and brittle.

    Fix all issues by adding docs and replacing the hard-coded default values with $BASE_ROOT_DIR.

  2. DrahtBot added the label Tests on Aug 4, 2026
  3. DrahtBot commented at 1:17 PM on August 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35879.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK willcl-ark

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35877 (build: ci/doc win64-cross build via nix by maflcko)
    • #32387 (ipc: add windows support by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. fanquake requested review from willcl-ark on Aug 4, 2026
  5. ci: Fix $BASE_ROOT_DIR installation fae7ba9aba
  6. maflcko force-pushed on Aug 7, 2026
  7. willcl-ark approved
  8. willcl-ark commented at 7:39 AM on August 7, 2026: member

    ACK fae7ba9abae8c5bec72b1c79bdd2480bade89399

  9. fanquake merged this on Aug 7, 2026
  10. fanquake closed this on Aug 7, 2026

  11. maflcko deleted the branch on Aug 7, 2026
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-10 21:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me