No description provided.
use english for all reason strings in IsStandardTx() #3589
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:english-reason changing 1 files +1 −1-
Diapolo commented at 11:14 AM on January 27, 2014: none
-
-
sipa commented at 8:55 PM on January 27, 2014: member
Wut? Why the hell was that merged?
-
-
Diapolo commented at 9:29 PM on January 27, 2014: none
Right, I remember I posted a mild protest in the pull, but didn't want to sound like the all-day-long nitter. Edit: After the merge I even started giving serious protests (https://github.com/bitcoin/bitcoin/commit/be484db274e6de7e7b6880d04b2d84e20b719b9a) no one seemed to care...
-
gmaxwell commented at 10:27 PM on January 27, 2014: contributor
data-size is perhaps confusing, since I'd expect that to be e.g. for txn >100kb. Would op-return-data-size be too verbose?
-
laanwj commented at 3:15 AM on January 28, 2014: member
Agreed. "multi-op-return" was Gavin's proposal and makes sense.
-
use english for all reason strings in IsStandardTx() b34e88a88f
-
BitcoinPullTester commented at 7:20 AM on January 28, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b34e88a88f8e8c0b73292853fbce73a5f86c7dcc for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
jgarzik commented at 7:27 AM on January 28, 2014: contributor
You guys have absolutely no sense of humor whatsoever. :)
-
laanwj commented at 7:52 AM on January 28, 2014: member
return "no-mucho-humor" - jgarzik referenced this in commit 12e1fcc34e on Jan 28, 2014
- jgarzik merged this on Jan 28, 2014
- jgarzik closed this on Jan 28, 2014
- Diapolo deleted the branch on Jan 28, 2014
- DrahtBot locked this on Sep 8, 2021
