The specific behaviour tied to the // TODO: allow witness replacement in packages. had no functional test anywhere, just the unit test coverage, showing the underlying mempool logic and not the RPC's actual JSON output.
This test submits a same-txid-different-witness transaction via submitpackage while its counterpart is already in the mempool, and asserts submitpackage correctly reports other-wtxid pointing at the transaction already in the mempool, its existing, documented behavior, not something this change introduces.
Verified the test can actually fail by temporarily asserting the wrong wtxid and confirmed it fails as expected.
test: cover submitpackage other-wtxid for same-txid-diff-witness #35893
pull mercie-ux wants to merge 1 commits into bitcoin:master from mercie-ux:test-submitpackage-other-wtxid changing 1 files +32 −0-
mercie-ux commented at 6:50 AM on August 5, 2026: none
-
ec8a53618e
test: cover submitpackage other-wtxid for same-txid-diff-witness
The specific behaviour tied to the `// TODO: allow witness replacement in packages.` had no functional test anywhere, just the unit test coverage, showing the underlying mempool logic and not the RPC's actual JSON output. This test submits a same-txid-different-witness transaction via `submitpackage` while its counterpart is already in the mempool, and asserts `submitpackage` correctly reports `other-wtxid` pointing at the transaction already in the mempool, its existing, documented behavior, not something this change introduces. Verified the test can actually fail by temporarily asserting the wrong wtxid and confirmed it fails as expected.
- DrahtBot added the label Tests on Aug 5, 2026
-
DrahtBot commented at 6:50 AM on August 5, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35893.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
instagibbs commented at 1:55 PM on August 9, 2026: member
concept ack
Contributors
Labels