cmake: Add `-Wunused-template` to `warn_interface` #35905

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:260805-unused-templates changing 2 files +10 −3

hebasto commented at 6:41 PM on August 5, 2026: member

Clang recently enabled -Wunused-template under -Wall (see https://github.com/llvm/llvm-project/pull/208001). This change enables the diagnostic for older Clang versions as well, notably those used in the CI.

The minisketch subtree is exempted until it includes the upstream fix from https://github.com/bitcoin-core/minisketch/pull/102.

cmake: Rename `minisketch_common` -> `nowarn_minisketch_interface`

The new name is more specific and follows the naming convention used for
the leveldb subtree.

48aa11612b

cmake: Add `-Wunused-template` to `warn_interface`

Clang recently enabled `-Wunused-template` under `-Wall` (see
https://github.com/llvm/llvm-project/pull/208001). This change enables
the diagnostic for older Clang versions as well, notably those used in
the CI.

The minisketch subtree is exempted until it includes the upstream fix
from https://github.com/bitcoin-core/minisketch/pull/102.

155bc910c5

hebasto added the label Build system on Aug 5, 2026
DrahtBot commented at 6:41 PM on August 5, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35905.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #35911 (Warn on and add missing [[noreturn]] by fanquake)
- #31507 (build: Use clang-cl to build on Windows natively by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake commented at 6:55 PM on August 5, 2026: member

~0 if it's already part of -Wall. We'll be using Clang 23 in the CI shortly.
hebasto commented at 7:06 PM on August 5, 2026: member

~0 if it's already part of -Wall. We'll be using Clang 23 in the CI shortly.

The CI will fail without either https://github.com/bitcoin-core/minisketch/pull/102 or:https://github.com/bitcoin/bitcoin/blob/155bc910c5f551cf2cba1ef907849d255f157fca/cmake/minisketch.cmake#L39-L44
fanquake commented at 7:34 PM on August 5, 2026: member

Yea. I expect we'll just update the subtree (and then not need to make, or make an revert, any other changes).

Contributors

Labels

cmake: Add `-Wunused-template` to `warn_interface` #35905

Code Coverage & Benchmarks

Reviews

Conflicts