refactor: Remove unused newFeeRate var in ReplacementChecks #35910

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2608-newFeeRate changing 1 files +0 −2
  1. maflcko commented at 9:24 AM on August 6, 2026: member

    This is unused since cluster-mempool, so it seems confusing to keep around. See the commit that forgot to remove it:

    $ git show 216e6937290338950215795291dbf0a533e234cf -U99999 | grep newFeeRate
         CFeeRate newFeeRate(ws.m_modified_fees, ws.m_vsize);
    -    if (const auto err_string{PaysMoreThanConflicts(ws.m_iters_conflicting, newFeeRate, hash)}) {
    
  2. refactor: Remove unused newFeeRate var in ReplacementChecks
    This is unused since cluster-mempool. See the commit that forgot to
    remove it:
    
    ```sh
    $ git show 216e6937290338950215795291dbf0a533e234cf -U99999 | grep newFeeRate
         CFeeRate newFeeRate(ws.m_modified_fees, ws.m_vsize);
    -    if (const auto err_string{PaysMoreThanConflicts(ws.m_iters_conflicting, newFeeRate, hash)}) {
    ```
    fa9a9a82ac
  3. DrahtBot added the label Refactoring on Aug 6, 2026
  4. DrahtBot commented at 9:24 AM on August 6, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35910.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK sedited

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. sedited approved
  6. sedited commented at 10:52 AM on August 6, 2026: contributor

    ACK fa9a9a82acd4804502cdc5fc00ffd1698920d157

  7. sedited merged this on Aug 6, 2026
  8. sedited closed this on Aug 6, 2026

  9. maflcko deleted the branch on Aug 6, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-21 19:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me