Wallet, refactor: Remove orphaned EraseWatchOnly function #35924

pull vicjuma wants to merge 1 commits into bitcoin:master from vicjuma:wallet-remove-erasewatchonly changing 2 files +0 −9

vicjuma commented at 12:16 AM on August 7, 2026: contributor

Summary This is a follow-up PR for #28710 by achow101 where bool LegacyScriptPubKeyMan::RemoveWatchOnly(const CScript &dest) which was the only remaining caller for the function EraseWatchOnly was removed. This PR is just a cleanup to remove the orphaned function.

Wallet, refactor: Remove orphaned EraseWatchOnly function

Removed a function whose caller was removed in a previous merged PR

6304789a18

DrahtBot commented at 12:16 AM on August 7, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35924.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK pablomartin4btc, jeanpablojp

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
pablomartin4btc commented at 3:01 AM on August 7, 2026: member

ACK 6304789a18f9391ff70bf8eed649bdecf176a086
jeanpablojp commented at 1:41 AM on August 8, 2026: none

ACK 6304789a18f9391ff70bf8eed649bdecf176a086

I have tested the code.

EraseWatchOnly lost its last caller in 83af1a3cca ("wallet: Delete LegacySPKM", January 2024). WriteWatchOnly is still called from src/bench/wallet_migration.cpp:76 and the WATCHS and WATCHMETA records are still read on migration, so removing only the erase half is the right split.

Built the merge with master (1be0b46297) with wallet, tests and bench enabled: no errors, full unit suite passes.
fanquake merged this on Aug 11, 2026
fanquake closed this on Aug 11, 2026

Type	Reviewers
ACK	pablomartin4btc, jeanpablojp

Contributors