doc: fix outdated URL in hash_tests.cpp #35995

pull cyb3ralbert wants to merge 1 commits into bitcoin:master from cyb3ralbert:patch-4 changing 1 files +1 −1
  1. cyb3ralbert commented at 2:41 PM on August 17, 2026: contributor

    The old URL still 301-redirects, but to the site root, not to the file — and the file itself is gone: the same path on the new domain returns 404. The author's page at https://www.aumasson.jp/siphash/ says that the SipHash page and documentation have moved to github.com/veorq/SipHash.

    The vectors now live in vectors.h in that repository. All 64 values match the array below.

  2. doc: fix outdated URL in hash_tests.cpp 158efbc723
  3. DrahtBot commented at 3:14 PM on August 17, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35995.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK l0rinc, maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. in src/test/hash_tests.cpp:100 in 158efbc723
      96 | @@ -97,7 +97,7 @@ BOOST_AUTO_TEST_CASE(murmurhash3)
      97 |     ...
      98 |     in = 00 01 02 ... 3e (63 bytes)
      99 |  
     100 | -   from: https://131002.net/siphash/siphash24.c
     101 | +   from: https://github.com/veorq/SipHash/blob/master/vectors.h
    


    l0rinc commented at 6:32 PM on August 17, 2026:

    The old siphash24.c URL now redirects to Aumasson's homepage.

    Checked https://github.com/veorq/SipHash/blob/32d067603b93b47828700880649198e0bfbbcffa/vectors.h, it matches all cases here and in the src/test/data/siphash.json file (I guess it's fine to duplicate the exact same test cases).

    https://lkml.indiana.edu/hypermail/linux/kernel/1909.0/04404.html also indicates this is a fair replacement:

    Test vectors taken from official reference source available at:

    Test vectors taken from reference source available at:

  5. l0rinc approved
  6. l0rinc commented at 6:33 PM on August 17, 2026: contributor

    tested ACK 158efbc723d37eefb06939b7f7e851c8168342bd

  7. maflcko commented at 5:48 AM on August 18, 2026: member

    lgtm ACK 158efbc723d37eefb06939b7f7e851c8168342bd

  8. fanquake merged this on Aug 18, 2026
  9. fanquake closed this on Aug 18, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-21 04:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me