This PR:
PushWarnings in RPC callsimportdescriptors and by a new warnings field on getdescriptorinfo (which also exposes the existing miniscript older() warnings)Cloning internal to musig() is not warned: both musig(A,B)/<0;1>/* and musig(A/<1;2>,B) derive a distinct aggregate key per branch, so nothing observable is reused.
closes #35985
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36005.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | jeanpablojp |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
<!--85328a0da195eb286784d51f73fa0af9-->
🚧 At least one of the CI tasks failed.
<sub>Task previous releases: https://github.com/bitcoin/bitcoin/actions/runs/32101345101/job/95602400388</sub>
<sub>LLM reason (✨ experimental): CI failed due to a GCC 12 internal compiler error (segmentation fault) while compiling src/rpc/blockchain.cpp.</sub>
Edit: Looks like the ICE was due to a corrupt VM/hardware
tACK 13ef865f84fc5d0f7073e11a6b4167b2dcd45e92
Built and ran the unit tests plus rpc_getdescriptorinfo.py and wallet_importdescriptors.py. I dropped each of the four multipath_cloned = true lines one at a time and each one fails on a different descriptor in the new unit test, and reverting only the PushWarnings dedup fails both functional tests.
1353 | + auto descs = Parse(desc, keys, error); 1354 | + BOOST_REQUIRE_MESSAGE(!descs.empty(), desc + ": " + error); 1355 | + for (const auto& d : descs) { 1356 | + const auto warnings = d->Warnings(); 1357 | + if (expect_warning) { 1358 | + BOOST_REQUIRE_MESSAGE(warnings.size() == 1U, desc);
nit: this only allows one warning. I hit both with wsh(and_v(v:pk(A/<0;1>/*),and_v(v:pk(B/0/*),older(65536)))), which nothing covers at the moment. Worth adding one?