Printing the exit code (like printing the stderr) seems independently useful, but should also help to debug the Windows CI failures, which have an empty stderr and truncated combined log:
test: Print os exit code on failure #36010
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2608-test-print-exit-code changing 1 files +3 −3-
maflcko commented at 12:19 PM on August 18, 2026: member
-
test: Print os exit code on failure fada80192b
- DrahtBot added the label Tests on Aug 18, 2026
-
DrahtBot commented at 12:19 PM on August 18, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36010.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK sedited If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 12:19 PM on August 18, 2026: member
Can be tested by applying this diff:
diff --git a/test/functional/wallet_disable.py b/test/functional/wallet_disable.py index 17b327e17e..781a7e51a6 100755 --- a/test/functional/wallet_disable.py +++ b/test/functional/wallet_disable.py @@ -20,3 +20,6 @@ class DisableWalletTest (BitcoinTestFramework): - def run_test (self): + def run_test(self): + self.stop_nodes() + import os + os._exit(123) # Make sure wallet is really disabledAnd then running it. E.g:
./bld-cmake/test/functional/test_runner.py wallet_disable --combinedlogslen 5 - sedited approved
-
sedited commented at 4:12 PM on August 18, 2026: contributor
tACK fada80192bdd9e350424591661fe418029c8e64e
- sedited merged this on Aug 18, 2026
- sedited closed this on Aug 18, 2026
- maflcko deleted the branch on Aug 18, 2026