psbt: Remove unused `IsNull()` methods #36012

pull nebula-21 wants to merge 1 commits into bitcoin:master from nebula-21:remove-psbt-isnull changing 3 files +0 −21

nebula-21 commented at 6:26 PM on August 18, 2026: contributor

This PR removes the IsNull() methods from PartiallySignedTransaction, PSBTInput, and PSBTOutput, along with their calls from the fuzz target.

This methods have no production callers, their only callers are the fuzz target. As such, keeping these methods seems not useful.

The motivation for this PR came from jeanpablojp's comment on #35848, added him as coauthor.
DrahtBot added the label PSBT on Aug 18, 2026
DrahtBot commented at 6:26 PM on August 18, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36012.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK vicjuma, maflcko, sedited

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
nebula-21 force-pushed on Aug 18, 2026
DrahtBot added the label CI failed on Aug 18, 2026

Type	Reviewers
ACK	vicjuma, maflcko, sedited

psbt: Remove unused IsNull() methods

Co-authored-by: jeanpablojp <8968629+jeanpablojp@users.noreply.github.com>

2c16efbb7b

DrahtBot removed the label CI failed on Aug 18, 2026
in src/test/fuzz/psbt.cpp:1 in 2c16efbb7b

vicjuma commented at 9:53 PM on August 18, 2026:

They were added in #17136 and according to the author

Add fuzzing harness for various PSBT related functions.

They were just added because they were in the psbt.cpp at the time. Probably they do not touch the PSBT fuzzer as per their comment.

vicjuma commented at 10:03 PM on August 18, 2026:

Added in src/script/sign.cpp by #13557 and refactored by #14978 to src/psbt.cpp I haven't really seen their usage other than them being privileged to be in the psbt.cpp file for fuzzing implementation :-).

vicjuma commented at 10:04 PM on August 18, 2026:

as above
vicjuma commented at 10:09 PM on August 18, 2026: contributor

ACK 2c16efbb7b5b5f0b188f320d9d4c92af602e9128

maflcko commented at 2:25 PM on August 19, 2026: member

Seems fine to remove. Should be trivial to add them back, if ever needed.

review ACK 2c16efbb7b5b5f0b188f320d9d4c92af602e9128 🥑

<details><summary>Show signature</summary>

Signature:

untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
trusted comment: review ACK 2c16efbb7b5b5f0b188f320d9d4c92af602e9128 🥑
wpG/reXKuwniQkW7MEJaODGqK6Q2/GAbPyachkX+YwRhmnpW2Isuo/cNx/EvhBJDtnPbWZORCBqoIcxpExOdAw==

</details>

sedited approved
sedited commented at 4:21 PM on August 19, 2026: contributor

ACK 2c16efbb7b5b5f0b188f320d9d4c92af602e9128
sedited merged this on Aug 19, 2026
sedited closed this on Aug 19, 2026

Contributors

Labels

Linked (view graph)

#35848 test: Cover `IsNull()` for PSBT, PSBTInput, PSBTOutput

psbt: Remove unused `IsNull()` methods #36012

Code Coverage & Benchmarks

Reviews