There were lingering comments from when HTTPRequest::m_client was a shared_ptr.
Prompted by #36007 (comment).
Follow-up to #36007.
doc: Correct after HTTPRequest::m_client changed to weak_ptr #36020
pull hodlinator wants to merge 1 commits into bitcoin:master from hodlinator:2026/08/http_weakptr_doc changing 2 files +5 −4-
hodlinator commented at 9:29 AM on August 19, 2026: contributor
-
doc: Correct comments after HTTPRequest::m_client was changed from shared to weak pointer 15e5c35c45
- DrahtBot added the label Docs on Aug 19, 2026
-
DrahtBot commented at 9:29 AM on August 19, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36020.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK winterrdog If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #35829 (http: Make class fields private and make HTTPResponse a struct by hodlinator)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- fanquake requested review from fjahr on Aug 19, 2026
- fanquake added this to the milestone 32.0 on Aug 19, 2026
-
winterrdog commented at 11:46 AM on August 19, 2026: contributor
ACK 15e5c35c4513688ea58d56bfdd678baa02c35b87
the comments correctly align with what the code is doing
- fanquake merged this on Aug 20, 2026
- fanquake closed this on Aug 20, 2026
- Kino1994 referenced this in commit 0375b1fffd on Aug 23, 2026
- alexanderwiederin referenced this in commit 7d78074ef7 on Sep 2, 2026
- hodlinator deleted the branch on Sep 21, 2026
Contributors
Labels
Milestone
32.0