build: Always define HAVE_SYSTEM #36023

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2026/08/have-system changing 1 files +1 −1
  1. Sjors commented at 1:26 PM on August 19, 2026: member

    When this feature is unavailable, #cmakedefine leaves its macro undefined, triggering -Wundef. I noticed this while building the kernel for iOs.

    Use #cmakedefine01 to always generate 0 or 1.

  2. DrahtBot added the label Build system on Aug 19, 2026
  3. DrahtBot commented at 1:26 PM on August 19, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36023.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. fanquake commented at 1:35 PM on August 19, 2026: member

    I haven't observed HAVE_FDATASYNC myself, but applied the same change anyway.

    Please don't make random changes for no reason.

  5. hebasto commented at 1:36 PM on August 19, 2026: member

    Maybe simply revert 976b034b13d28877aee641833d5ee28a8cc5d83f?

  6. maflcko commented at 1:46 PM on August 19, 2026: member

    Ref: #16419

    Can we not use a single style and enforce it with a linter, similar to the lint_includes_build_config one?

  7. Sjors force-pushed on Aug 19, 2026
  8. DrahtBot added the label CI failed on Aug 19, 2026
  9. Sjors commented at 2:04 PM on August 19, 2026: member

    @fanquake I dropped HAVE_FDATASYNC. It was deliberately made this way in #19803 for some reason. @hebasto using #if defined(HAVE_SYSTEM) looks ugly imo, but it also risks someone using #if HAVE_SYSTEM accidentally.

  10. build: Always define HAVE_SYSTEM
    When this feature is unavailable, #cmakedefine leaves its macro
undefined, triggering -Wundef. Use #cmakedefine01 to always generate 0
or 1.
    013fffe371
  11. Sjors force-pushed on Aug 19, 2026
  12. Sjors renamed this:
    build: Always define HAVE_SYSTEM and HAVE_FDATASYNC
    build: Always define HAVE_SYSTEM
    on Aug 19, 2026
  13. DrahtBot removed the label CI failed on Aug 19, 2026
Contributors
SjorsDrahtBotfanquakehebastomaflcko
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-21 04:51 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me