test: make index crash test check saved state #36059

pull l0rinc wants to merge 2 commits into bitcoin:master from l0rinc:l0rinc/test-preserve-index-crash-state changing 1 files +7 −2

l0rinc commented at 3:48 AM on August 23, 2026: contributor

Problem: #35847 moved the unclean-shutdown test into the shared base index tests, but it checked only that each index could reopen and start background sync. Both checks also pass when the index reopens at height 0, so they do not verify that a height-100 checkpoint was saved before the simulated crash and reloaded afterward.

Fix: The first commit records the existing false positive by asserting that each index reopens at height 0 before background sync. The second commit establishes a durable checkpoint at height 100, drains its setup notification, and changes the same assertion to the pre-crash height.

test: expose missing index crash checkpoint

`index_unclean_shutdown` previously checked only that each index could reopen and start background sync after the simulated crash.
An empty index at height 0 satisfies both checks, so the test could pass without preserving any pre-crash checkpoint.

Assert the current reopened height before background sync to make the false positive explicit.

5aa15df60c

test: preserve index crash test state

Flush the chainstate at the current tip and drain its notification before registering any index.
This lets each end-of-sync `Commit()` persist the pre-crash height and keeps the setup callback out of the simulated crash window.

Replace the TODO-marked `0` expectation with the captured tip height.
The check runs before background sync, so rebuilding cannot hide a missing checkpoint.

7ea36e985a

DrahtBot added the label Tests on Aug 23, 2026
DrahtBot commented at 3:48 AM on August 23, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36059.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK jeanpablojp

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
jeanpablojp commented at 8:34 PM on August 23, 2026: contributor

tACK 7ea36e985a900b2291ce549e468f6baab5324dc6

Good catch. Built and ran the tests, nothing else came up.

Type	Reviewers
ACK	jeanpablojp

Contributors

Labels

Linked (view graph)

#35847 test: move more tests to `baseindex_tests` and run them for all indexes

test: make index crash test check saved state #36059

Code Coverage & Benchmarks

Reviews