test: refactor: Remove confusing ignore_errors=True #36065

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2608-test-less-ignore_errors-True changing 1 files +7 −8
  1. maflcko commented at 12:37 PM on August 24, 2026: member

    There is an unexplained ignore_errors=True in the internal _initialize_chain helper:

    
    shutil.rmtree(cache_path('fees'), ignore_errors=True)
    

    This is fine, because no error should happen. But it is a bit confusing, because an ignored error may lead to a later error anyway.

    Fix that by failing early instead.

    Also, re-write the simple block to pathlib.

  2. test: refactor: Remove confusing ignore_errors=True fa43bb80f5
  3. DrahtBot added the label Tests on Aug 24, 2026
  4. DrahtBot commented at 12:37 PM on August 24, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36065.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-24 13:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me