refactor: fuzz: remove cost_of_change from coin-grinder fuzz target #36071

pull yancyribbens wants to merge 1 commits into bitcoin:master from yancyribbens:0824-remove-cost-of-change-from-cg-fuzzer changing 1 files +0 −1

yancyribbens commented at 6:32 PM on August 24, 2026: contributor

coin-grinder selection algorithm does not take cost_of_change as a parameter.

CoinGrinder doesn’t use coin_params.m_cost_of_change and the comparison of selection results from CoinGrinder, SRD, and Knapsack does not need it either as only the weight of the selections is relevant. So, line 96 in that fuzz test is both incorrect and dead code. It should be removed.

cite: stackexchange

verified coin_grinder fuzz target still works after removal

refactor: fuzz: remove cost_of_change from coin-grinder fuzz target

coin-grinder selection algorithm does not take cost_of_change as a
parameter.

5ec6446a1b

DrahtBot added the label Refactoring on Aug 24, 2026
DrahtBot commented at 6:33 PM on August 24, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36071.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK brunoerg

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
yancyribbens commented at 6:33 PM on August 24, 2026: contributor

cc @murchandamus
brunoerg approved
brunoerg commented at 5:43 PM on August 25, 2026: contributor

ACK 5ec6446a1b83e673a51d9e86fa4c0c0e9930fccc

m_cost_of_change isn't used for anything of coin-grinder, it's a no-op in the target and it's fine to remove it.

Type	Reviewers
ACK	brunoerg

Contributors

Labels