In "test: Add display operator<< overloads to common.{h,cpp}" 05bd1513be2d9aaeb0a94671024f585f0d3cca15
nit: add context to what we are displaying here and other places.
<details>
<summary>diff</summary>
diff --git a/src/test/util/common.cpp b/src/test/util/common.cpp
index ea9b42525a..6f0229c21e 100644
--- a/src/test/util/common.cpp
+++ b/src/test/util/common.cpp
@@ -44,7 +44,7 @@ std::ostream& operator<<(std::ostream& os, const CExtKey& k)
if (!k.key.IsValid()) return os << "CExtKey(<invalid>)";
unsigned char code[BIP32_EXTKEY_SIZE];
k.Encode(code);
- return os << strprintf("CExtKey(%s)", HexStr(code));
+ return os << strprintf("CExtKey(encoded=%s)", HexStr(code));
}
std::ostream& operator<<(std::ostream& os, const CExtPubKey& k)
@@ -52,7 +52,7 @@ std::ostream& operator<<(std::ostream& os, const CExtPubKey& k)
if (k.pubkey.size() != CPubKey::COMPRESSED_SIZE) return os << "CExtPubKey(<invalid>)";
unsigned char code[BIP32_EXTKEY_SIZE];
k.Encode(code);
- return os << strprintf("CExtPubKey(%s)", HexStr(code));
+ return os << strprintf("CExtPubKey(encoded=%s)", HexStr(code));
}
std::ostream& operator<<(std::ostream& os, const FeeFrac& ff)
@@ -67,32 +67,32 @@ std::ostream& operator<<(std::ostream& os, const ByRatioNegSize<FeeFrac>& b)
std::ostream& operator<<(std::ostream& os, const CNoDestination& dest)
{
- return os << strprintf("CNoDestination(%s)", HexStr(dest.GetScript()));
+ return os << strprintf("CNoDestination(script=%s)", HexStr(dest.GetScript()));
}
std::ostream& operator<<(std::ostream& os, const PubKeyDestination& dest)
{
- return os << strprintf("PubKeyDestination(%s)", HexStr(dest.GetPubKey()));
+ return os << strprintf("PubKeyDestination(pubkey=%s)", HexStr(dest.GetPubKey()));
}
std::ostream& operator<<(std::ostream& os, const PKHash& h)
{
- return os << strprintf("PKHash(%s)", h.ToString());
+ return os << strprintf("PKHash(hash=%s)", h.ToString());
}
std::ostream& operator<<(std::ostream& os, const ScriptHash& h)
{
- return os << strprintf("ScriptHash(%s)", h.ToString());
+ return os << strprintf("ScriptHash(hash=%s)", h.ToString());
}
std::ostream& operator<<(std::ostream& os, const WitnessV0KeyHash& h)
{
- return os << strprintf("WitnessV0KeyHash(%s)", h.ToString());
+ return os << strprintf("WitnessV0KeyHash(hash=%s)", h.ToString());
}
std::ostream& operator<<(std::ostream& os, const WitnessV0ScriptHash& h)
{
- return os << strprintf("WitnessV0ScriptHash(%s)", h.ToString());
+ return os << strprintf("WitnessV0ScriptHash(hash=%s)", h.ToString());
}
std::ostream& operator<<(std::ostream& os, const WitnessUnknown& w)
@@ -107,7 +107,7 @@ std::ostream& operator<<(std::ostream& os, const PayToAnchor& p)
std::ostream& operator<<(std::ostream& os, const WitnessV1Taproot& t)
{
- return os << strprintf("WitnessV1Taproot(%s)", HexStr(t));
+ return os << strprintf("WitnessV1Taproot(program=%s)", HexStr(t));
}
std::ostream& operator<<(std::ostream& os, const CTxDestination& dest)
@@ -118,7 +118,7 @@ std::ostream& operator<<(std::ostream& os, const CTxDestination& dest)
std::ostream& operator<<(std::ostream& os, const CPubKey& pk)
{
- return os << strprintf("CPubKey(%s)", HexStr(pk));
+ return os << strprintf("CPubKey(pubkey=%s)", HexStr(pk));
}
std::ostream& operator<<(std::ostream& os, const KeyOriginInfo& info)
</details>
