A refactor to remove unused client streams from a squash in #31741. These two are constant streams have no inputs directed to them. client_destroy appears to be used as a no-op in client_destroy.str(), warranting its removal. The client construction is delegated via the ProxyClientCustom::ProxyClientCustom;. This PR just removed them entirely. If they were placed there for future use, please notify.
refactor: remove unused client streams #36108
pull vicjuma wants to merge 1 commits into bitcoin:master from vicjuma:refactor/remove-unused-client-streams changing 1 files +1 −4-
vicjuma commented at 8:35 PM on August 27, 2026: contributor
-
bb7789c0e4
refactor: remove unused client streams
these client_construct and client_destroy streams were created but there is no input directed to them. This makes the use of `client_destroy` in `client_destroy.str()` a no op warranting its removal
- DrahtBot added the label Refactoring on Aug 27, 2026
-
DrahtBot commented at 8:35 PM on August 27, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36108.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
fanquake commented at 8:38 PM on August 27, 2026: member
Thanks, but this needs to go upstream to the https://github.com/bitcoin-core/libmultiprocess repo.
- fanquake closed this on Aug 27, 2026
Labels