The iwyu CI may modify subtrees when iwyu thinks a header inside a subtree is "associated" (due to the naming).
This happens to not be a problem on current master, but can become a problem if an iwyu-enforced file is renamed or a file is iwyu-enforced in the future.
Fix this by excluding subtrees.
Can be tested by running the iwyu CI on src/test/fuzz/minisketch.cpp and seeing a change in minisketch.h before this CI fix.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36112.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | hebasto |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
src/rpc and treat them as errors by hebasto)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
Concept ACK.
2 | @@ -3,14 +3,16 @@ 3 | // file COPYING or http://www.opensource.org/licenses/mit-license.php. 4 | 5 | #include <minisketch.h> 6 | -#include <node/minisketchwrapper.h> 7 | +
Regardless of IWYU treating <minisketch.h> as an "associated" header, I don't think that justifies a separate group of includes, because it's not a real associated header and does not declare anything defined in this source file.
I think it is harmless (and intentional?) clang-format behavior. In fact it may be fine or minimally preferable to treat/document this as associated? In fact the current clang-format seems to hint at this:
IncludeIsMainRegex: '(Test)?$'
Which is the default value added via 13f36c020f0329b5e975282b45292fdf2a495e31.
The alternatives are certainly worse: Some ugly // clang-format off or a test-specific src/test/.clang-format:
BasedOnStyle: InheritParentConfig
IncludeIsMainRegex: 'off^'
ACK fa0ebc77d35d63d665bcb5dde8167346d6856a82.
Thank you for handling this!
Noted in the last iwyu PR: https://github.com/bitcoin/bitcoin/pull/35900#pullrequestreview-5040554983
re-ACK fa3971011d1eef383c5b4cc03cc6b278900c0920.