doc: Correct comment about which subsystem detects lagging clocks #36134

pull hodlinator wants to merge 1 commits into bitcoin:master from hodlinator:2026/08/doc_fix_headers_sync changing 1 files +4 −4
  1. hodlinator commented at 7:36 PM on August 31, 2026: contributor

    Turns out a completely fresh datadir means there is no chain state to load and hence no detection of a lagging clock occurs in that subsystem. Instead we do proceed into attempting to start a headers sync.

    <details><summary>Diff to repro with fresh -datadir</summary>

    --- a/src/init.cpp
    +++ b/src/init.cpp
    @@ -1499,6 +1499,8 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
         const ArgsManager& args = *Assert(node.args);
         const CChainParams& chainparams = Params();
     
    +    SetMockTime(chainparams.GenesisBlock().Time() - 3h);
    +
         auto opt_max_upload = ParseByteUnits(args.GetArg("-maxuploadtarget", DEFAULT_MAX_UPLOAD_TARGET), ByteUnit::M);
         if (!opt_max_upload) {
             return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s'"), args.GetArg("-maxuploadtarget", "")));
    

    </details>

    Follow-up to #35351

  2. doc: Correct comment about which subsystem detects lagging clocks 55390d1827
  3. DrahtBot added the label Docs on Aug 31, 2026
  4. DrahtBot commented at 7:36 PM on August 31, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36134.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK sedited, jonatack

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. sedited approved
  6. sedited commented at 7:51 PM on August 31, 2026: contributor

    ACK 55390d1827c724b8c09ac9ffa4b97fccb370b322

  7. jonatack commented at 4:48 AM on September 1, 2026: member

    ACK 55390d1827c724b8c09ac9ffa4b97fccb370b322

    Suggested in perspicacious #35351#pullrequestreview-5066794487 by @mzumsande.

  8. fanquake merged this on Sep 1, 2026
  9. fanquake closed this on Sep 1, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-08 12:50 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me