This adds the generated and height fields to the JSON REST endpoint /rest/spenttxouts/BLOCKHASH.json to match the prevout output of the getblock RPC with verbosity 3. The information for these fields is already available, but just was not exposed.
The binary and hex formats aren't changed (here) to not break backwards compatibility with consumers of these endpoints. See the discussion in #32540 (comment)
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36251.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | nervana21, willcl-ark, sedited |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
This adds the `generated` and `height` fields to the JSON REST
endpoint `/rest/spenttxouts/BLOCKHASH.json` to match the prevout
output of the getblock RPC with verbosity 3. The information for
these fields is already available, but just was not exposed.
The binary and hex formats aren't changed (here) to not break
backwards compatibility with consumers of these endpoints. See the
discussion in https://github.com/bitcoin/bitcoin/pull/32540#issuecomment-5665279713
Concept ACK
tACK 1566a4767afd3865ee466d1aa2ce8237cb5c27c1
ACK 1566a4767afd3865ee466d1aa2ce8237cb5c27c1
Seems like a useful addition to me.
I am not that familiar with REST best-practices, but adding a field to a response seems likely to be OK, as client usually read the fields they need and ignore ones they don't know about.
I suppose a new client requesting from an un-upgraded node might panic if there are expected fields missing, but in that case they should just be using an upgraded node too.
ACK 1566a4767afd3865ee466d1aa2ce8237cb5c27c1