refactor: prune unused semi-colons #36268

pull fanquake wants to merge 4 commits into bitcoin:master from fanquake:extra_semicolons changing 62 files +97 −95
  1. fanquake commented at 9:58 AM on September 16, 2026: member

    Enable -Wextra-semi and delete all the redundant semicolons.

    Waiting on a pull of the libmultiprocess subtree.

  2. [nomerge] libmultiprocess fixups
    These will be pulled in with the next subtree update.
    86790fb8d6
  3. refactor: prevent trailing semi warning on TRACEPOINT_SEMAPHORE b736aab404
  4. DrahtBot added the label Refactoring on Sep 16, 2026
  5. DrahtBot commented at 9:58 AM on September 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36268.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36244 (validation, net: Process blocks asynchronously and reduce cs_main contention by w0xlt)
    • #35387 (logging: make trace logging easily usable by ryanofsky)
    • #34909 (wallet, refactor: modularise wallet by extracting out legacy wallet migration by rkrux)
    • #34486 (net: Reduce local network activity when networkactive=0 by willcl-ark)
    • #34213 (net: preserve anchors when network is disabled by brunoerg)
    • #34038 (logging: replace -loglevel with -trace, expose trace logging via RPC by ajtowns)
    • #31507 (build: Use clang-cl to build on Windows natively by hebasto)
    • #29700 (kernel, refactor: return error status on all fatal errors by ryanofsky)
    • #27865 (wallet: Track no-longer-spendable TXOs separately by achow101)
    • #27052 (test: rpc: add last block announcement time to getpeerinfo result by LarryRuane)
    • #26022 (Add util::ResultPtr class by ryanofsky)
    • #25665 (refactor: Add util::Result failure types and ability to merge result values by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. refactor: remove redundant semicolons b3dc9e6e6b
  7. build: add -Wextra-semi to warn flags c3e94cab4b
  8. fanquake force-pushed on Sep 16, 2026
  9. DrahtBot added the label CI failed on Sep 16, 2026
  10. DrahtBot commented at 10:21 AM on September 16, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/35082380885/job/104749176904</sub> <sub>LLM reason (✨ experimental): CI failed the lint “subtree” check because a subtree directory was modified without a corresponding subtree merge.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  11. DrahtBot added the label Needs rebase on Sep 22, 2026
  12. DrahtBot commented at 8:38 PM on September 22, 2026: contributor

    <!--cf906140f33d8803c4a75a2196329ecb-->

    🐙 This pull request conflicts with the target branch and needs rebase.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-28 10:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me