refactor: prune unused semi-colons #36268

Enable -Wextra-semi and delete all the redundant semicolons.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

External sites

• Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36268
• Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36268.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36268#author-ralph

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #36778 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36778.svg">} (assumeutxo: replace loadtxoutset RPC with a startup arg by l0rinc)
• #36167 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36167.svg">} (build: Enable -Wunused by fanquake)
• #35387 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35387.svg">} (logging: make trace logging easily usable by ryanofsky)
• #35355 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35355.svg">} (Use atomics for determining whether trace logging is enabled by ajtowns)
• #35302 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35302.svg">} (Silent Payments: Sending (take 2) by Eunovo)
• #34909 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/34909.svg">} (wallet, refactor: modularise wallet by extracting out legacy wallet migration by rkrux)
• #34038 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/34038.svg">} (logging: replace -loglevel with -trace, expose trace logging via RPC by ajtowns)
• #30343 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/30343.svg">} (wallet, logging: Replace WalletLogPrintf() with LogInfo() by ryanofsky)
• #27865 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/27865.svg">} (wallet: Track no-longer-spendable TXOs separately by achow101)
• #26022 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/26022.svg">} (Add util::ResultPtr class by ryanofsky)
• #25665 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/25665.svg">} (refactor: Add util::Result failure types and ability to merge result values by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

<!--85328a0da195eb286784d51f73fa0af9-->

🚧 At least one of the CI tasks failed. _{Task lint: https://github.com/bitcoin/bitcoin/actions/runs/35082380885/job/104749176904} _{LLM reason (✨ experimental): CI failed the lint “subtree” check because a subtree directory was modified without a corresponding subtree merge.}

<details><summary>Hints</summary>

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

• Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

• A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

• An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

</details>