build: ensure release binaries don't contain `depends` references #36270

pull fanquake wants to merge 4 commits into bitcoin:master from fanquake:check_no_depends changing 7 files +11 −2
  1. fanquake commented at 10:53 AM on September 16, 2026: member

    It doesn't make sense for the release binaries to contain references to depends, either in debug symbols, or in relation to runtime functionality, as it's unlikely that "depends" exists on a users system at runtime.

    There are a number of Qt (and sub dep) related changes here. Not completely sure what is the best approach for these. My current understanding is that most of these changes should be a no-op at runtime.

  2. guix: map depends paths b32f117501
  3. depends: set Qt -prefix to /usr
    Should avoid depends paths ending up in Guix binaries:
    
    /bitcoin/depends/x86_64-linux-gnu/share/X11/xkb
    ~/.local/share/icons:~/.icons:/bitcoin/depends/x86_64-linux-gnu/share/icons:/bitcoin/depends/x86_64-linux-gnu/share/pixmaps
    qt_prfxpath=/bitcoin/depends/x86_64-linux-gnu
    a0071950f0
  4. depends: patch out more Qt (dep) depends paths e0e6ce8af0
  5. contrib: check guix build doesn't have depends remnants 0526120145
  6. DrahtBot added the label Build system on Sep 16, 2026
  7. DrahtBot commented at 10:54 AM on September 16, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36270.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #25573 (guix: produce a -static-pie bitcoind by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-23 05:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me