build: ensure release binaries don't contain `depends` references #36270

pull fanquake wants to merge 4 commits into bitcoin:master from fanquake:check_no_depends changing 7 files +11 −2

fanquake commented at 10:53 AM on September 16, 2026: member

It doesn't make sense for the release binaries to contain references to depends, either in debug symbols, or in relation to runtime functionality (i.e loading fonts, icons, keyboard configs), as it's unlikely that "depends" exists on a users system at runtime.

There are a number of Qt (and sub dep) related changes here. Not completely sure what is the best approach for these. My current understanding is that most of these changes should be a no-op at runtime.
DrahtBot added the label Build system on Sep 16, 2026
DrahtBot commented at 10:54 AM on September 16, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36270
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36270.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36270#author-ralph


Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #36593 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36593.svg"></sub> (depends: Update Qt to 6.12.0 by hebasto)
- #25573 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/25573.svg"></sub> (guix: produce a -static-pie bitcoind by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
guix: map depends paths 18dea98ffd

depends: set Qt -prefix to /usr

Should avoid depends paths ending up in Guix binaries:

/bitcoin/depends/x86_64-linux-gnu/share/X11/xkb
~/.local/share/icons:~/.icons:/bitcoin/depends/x86_64-linux-gnu/share/icons:/bitcoin/depends/x86_64-linux-gnu/share/pixmaps
qt_prfxpath=/bitcoin/depends/x86_64-linux-gnu

9afbee8396

depends: patch out more Qt (dep) depends paths fff7ed379e
contrib: check guix build doesn't have depends remnants 6b6f29b0da
fanquake force-pushed on Nov 6, 2026
fanquake marked this as ready for review on Nov 6, 2026
fanquake commented at 1:18 PM on November 6, 2026: member

@hebasto have you got any thoughts on the Qt (or sub dep) related changes here?

Contributors

fanquake

DrahtBot

Labels

Build system

build: ensure release binaries don't contain `depends` references #36270

External sites

Reviews

Conflicts