A VERSION message from a non-inbound peer calls AddrMan::Good(),
which moves the address from the new table to the tried table. This was previously untested.
This PR kills the mutant at https://bitcoincore.space/src/net_processing.cpp#3475
test: non-inbound version message promotes address to tried table #36279
pull naiyoma wants to merge 1 commits into bitcoin:master from naiyoma:2026_3/test_version_message_good_addrman changing 1 files +63 −0-
naiyoma commented at 8:32 PM on September 16, 2026: contributor
-
14ed2012da
test: only non-inbound version message promotes address to tried table
A VERSION message from a non-inbound peer calls AddrMan::Good(), moving the peer's address from the new table to the tried table. Inbound peers are excluded. Co-authored-by: Bruno Garcia <brunoely.gc@gmail.com>
- DrahtBot added the label Tests on Sep 16, 2026
-
DrahtBot commented at 8:33 PM on September 16, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36279.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- naiyoma renamed this:
test: only non-inbound version message promotes address to tried table
test: non-inbound version message promotes address to tried table
on Sep 16, 2026
