Improvements to unit test setup #363

pull vegard wants to merge 6 commits into bitcoin:master from vegard:testing changing 10 files +93 −10

vegard commented at 1:45 PM on June 29, 2011: contributor

I made some changes in anticipation of unit tests for scripts and OP_CHECKSIG, etc.

Feedback is welcome.
Add missing includes to key.h 47fa9df20a
Add missing include to script.h 340ca649d9
Add missing includes to net.h e7c03592e5

Fix testing setup

There were some problems with the existing testing setup:

 - Makefile rules for test-file compilation used CFLAGS instead of
   CXXFLAGS in makefile.unix
 - Main test file included other test files verbatim using #include
 - Test files included bitcoin headers using #include "../foo.h"
   (this breaks when headers include other headers), so add -I. to
   the flags to make #include "foo.h" include the top-level foo.h.

(Only tested on Linux)

e207d9d811

Add prototype for EvalScript() to script.h
This is needed for the script unit tests.
5a9a9bfda3
Add a file for script tests 7bbaca0e33
gavinandresen commented at 1:50 PM on June 29, 2011: contributor

Nice! Thanks!
TheBlueMatt commented at 2:19 PM on July 4, 2011: member

Looks cool, however the -I. stuff kills MinGW building, so NACK that part.
gavinandresen commented at 2:27 PM on July 4, 2011: contributor

Is there a standard makefile syntax for "the directory that the makefile is in" ?

(it has been many years since I wrestled with makefiles....)
gavinandresen commented at 1:06 AM on July 18, 2011: contributor

vegard: ping? I'd very much like to pull this, will you have time soon to fix the mingw and undefined symbol problems?
vegard commented at 7:53 AM on July 18, 2011: contributor

On 18 July 2011 03:06, gavinandresen reply@reply.github.com wrote:

vegard: ping? I'd very much like to pull this, will you have time soon to fix the mingw and undefined symbol problems?

I'm not sure what to do about them. I don't have windows or mingw, and I don't see any undefined symbols here.

I can try to have a look next week.
gavinandresen commented at 8:59 AM on July 18, 2011: contributor

I'd suggest jumping on IRC and see if you can recruit somebody to help test/fix... (BlueMatt is very helpful).
gavinandresen commented at 4:23 PM on August 9, 2011: contributor

Pulled versions of these, Matt fixed them up.
gavinandresen closed this on Aug 9, 2011
lateminer referenced this in commit fc3bfab0db on Oct 16, 2019
Losangelosgenetics referenced this in commit d5a55e17e4 on Mar 12, 2020
cryptapus referenced this in commit 774b638fc1 on May 3, 2021
rajarshimaitra referenced this in commit f0f4fd483a on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)