wallet: accept uppercase addresses without amount in sendall #36375

sendall keeps the recipients that were given without an amount as the strings the user passed (spend.cpp:1399). Later it finds their outputs by comparing against EncodeDestination of each output script (spend.cpp:1564), which for bech32 is the canonical lowercase form.

An address given in uppercase is valid bech32, and validateaddress and sendtoaddress accept it. In sendall it never matches, so its output keeps the placeholder amount of 0 and the call fails:

sendall '["BCRT1Q..."]'
error code: -8
Specified output amount to bcrt1q... is below dust threshold.

This stores the decoded destinations of those addresses instead and compares them with the destinations of the outputs, so the match doesn't depend on how the address was written. Invalid addresses are still rejected later when the transaction is constructed.

The new sendall_uppercase_address in wallet_sendall.py sweeps the wallet to the uppercase form of an address. It fails on master with the dust error above and passes with the fix. wallet_send.py still passes.

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36375.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline and AI policy for information on the review process.

If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

you are fast

Concept~0

If we are doing this, maybe a better way would be to store CTxDestinations directly in the std::set so you can avoid Encode - Decode multiple times:

$ git diff
diff --git a/src/wallet/rpc/spend.cpp b/src/wallet/rpc/spend.cpp
index 1e85412c58..8a34b97b3d 100644
--- a/src/wallet/rpc/spend.cpp
+++ b/src/wallet/rpc/spend.cpp
@@ -1387,7 +1387,7 @@ RPCMethod sendall()
             PreventOutdatedOptions(options);
 
 
-            std::set<std::string> addresses_without_amount;
+            std::set<CTxDestination> addresses_without_amount;
             UniValue recipient_key_value_pairs(UniValue::VARR);
             const UniValue& recipients{request.params[0]};
             for (unsigned int i = 0; i < recipients.size(); ++i) {
@@ -1396,9 +1396,9 @@ RPCMethod sendall()
                     UniValue rkvp(UniValue::VOBJ);
                     rkvp.pushKV(recipient.get_str(), 0);
                     recipient_key_value_pairs.push_back(std::move(rkvp));
-                    // Store the canonical encoding, so it matches the outputs below
+                    // Store the decoded destination, so it matches the outputs below
                     // also when the address was given in another case (e.g. uppercase bech32)
-                    addresses_without_amount.insert(EncodeDestination(DecodeDestination(recipient.get_str())));
+                    addresses_without_amount.insert(DecodeDestination(recipient.get_str()));
                 } else {
                     recipient_key_value_pairs.push_back(recipient);
                 }
@@ -1562,8 +1562,7 @@ RPCMethod sendall()
             for (CTxOut& out : rawTx.vout) {
                 CTxDestination dest;
                 ExtractDestination(out.scriptPubKey, dest);
-                std::string addr{EncodeDestination(dest)};
-                if (addresses_without_amount.contains(addr)) {
+                if (addresses_without_amount.contains(dest)) {
                     out.nValue = per_output_without_amount;
                     if (!gave_remaining_to_first) {
                         out.nValue += remainder % addresses_without_amount.size();
@@ -1576,7 +1575,7 @@ RPCMethod sendall()
                 } else {
                     if (IsDust(out, pwallet->chain().relayDustFee())) {
                         // Specified output amount is dust
-                        throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", addr));
+                        throw JSONRPCError(RPC_INVALID_PARAMETER, strprintf("Specified output amount to %s is below dust threshold.", EncodeDestination(dest)));
                     }
                 }
             }

you are fast

Cause I am flash ⚡😁

Thanks, that's cleaner. Taken as suggested in df2994b14a.

ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851

lgtm ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851

ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851