test: Add SKIP_WRITE edge case to wallet_startup #36378

pull aaron-leeb wants to merge 1 commits into bitcoin:master from aaron-leeb:test-wallet-startup-skip-write changing 1 files +5 −0
  1. aaron-leeb commented at 3:40 AM on September 29, 2026: none

    Verifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.

    This improves test coverage for the dynamic settings logic introduced in #36176 by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.

    This specific edge case was suggested by contributor jeanpablojp here.

  2. test: Add SKIP_WRITE edge case to wallet_startup
    Verifies that reloading a wallet with load_on_startup=True when it is already in the startup list correctly evaluates to SKIP_WRITE and does not emit a warning under -nosettings.
    
    This improves coverage for the dynamic settings logic introduced in #36176 by ensuring the C++ short-circuit logic properly evaluates the action type before checking the settings path.
    
    This specific edge case was suggested by contributor jeanpablojp.
    774dd9b034
  3. DrahtBot added the label Tests on Sep 29, 2026
  4. DrahtBot commented at 3:40 AM on September 29, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36378.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-30 20:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me