fuzz: fix stale comments in http_request #36379

pull frankomosh wants to merge 1 commits into bitcoin:master from frankomosh:2026-09-fuzz-http-comment-fix changing 1 files +4 −4

frankomosh commented at 8:56 AM on September 29, 2026: contributor

Follow-up to #36135 (review), fixing a false comment flagged in review.

The comment says a completed request is always handed back to a worker. Since #36174 it stays in m_req when the send buffer is over MAX_BODY_SIZE.
DrahtBot added the label Fuzzing on Sep 29, 2026
DrahtBot commented at 8:56 AM on September 29, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36379
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36379.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36379#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK pinheadmz, hodlinator

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
in src/test/fuzz/http_request.cpp:129 in 2de494ee5c
```
 125 | @@ -126,7 +126,8 @@ void Drain(const std::shared_ptr<FuzzClient>& client, RunResult& out)
 126 |  
 127 |          if (!req) {
 128 |              if (const HTTPRequest* cur{client->GetRequest()}) {
 129 | -                // Complete is always handed back, never left behind.
 130 | +                // Complete is handed back unless the send buffer is over MAX_BODY_SIZE (see #36174),
```
maflcko commented at 9:06 AM on September 29, 2026:

Not sure about all the raw #id in code comments. Either the pull request context is important, and it should be a full URL, so that it is easily navigable, or it should just be removed or refer to the (other) code itself.

Same above: How is it relevant that ReadBody returned an empty string before 35182? The comments should explain the current code and context and not some irrelevant context or irrelevant history.

frankomosh commented at 9:29 AM on September 29, 2026:

dropping both
frankomosh force-pushed on Sep 29, 2026
DrahtBot added the label CI failed on Sep 29, 2026
frankomosh renamed this:
~~fuzz: correct stale comment about completed requests~~
fuzz: fix stale comments in http_request
on Sep 29, 2026
frankomosh force-pushed on Sep 29, 2026
DrahtBot removed the label CI failed on Sep 29, 2026
frankomosh commented at 6:46 PM on October 10, 2026: contributor

cc @pinheadmz

Type	Reviewers
ACK	pinheadmz, hodlinator

in src/test/fuzz/http_request.cpp:127 in c8bdd7f192

 122 | @@ -126,7 +123,8 @@ void Drain(const std::shared_ptr<FuzzClient>& client, RunResult& out)
 123 |  
 124 |          if (!req) {
 125 |              if (const HTTPRequest* cur{client->GetRequest()}) {
 126 | -                // Complete is always handed back, never left behind.
 127 | +                // A completed request is handed back to a worker unless the send buffer
 128 | +                // is full. Replies here are empty, so that cannot happen.

pinheadmz commented at 5:41 AM on October 14, 2026:

A bit more explicit:

We don't hand anything back to a worker, it'd be the first time we hand it to a worker
There's no workers in the test anyway

                // TryReadRequest() returns empty if the HTTPRemoteClient is still
                // holding on to the request. In this test the request is guaranteed
                // to be incomplete although in production it may a result of
                // a busy worker or a full send buffer.

frankomosh commented at 5:47 PM on October 14, 2026:

Thanks. Taken

frankomosh commented at 5:48 PM on October 14, 2026:

Said “incomplete or failed” since this branch could also be reached on a parse error.

fuzz: fix stale comments in http_request

A completed request is no longer always handed back to a worker; it stays
in m_req when the send buffer is full.

Also drop the pre-existing comment/note about what ReadBody() returned before the libevent
replacement.

Co-authored-by: Matthew Zipkin <pinheadmz@pm.me>

3f7f845cf5

frankomosh force-pushed on Oct 14, 2026
pinheadmz approved

pinheadmz commented at 9:38 PM on October 14, 2026: member

ACK 3f7f845cf51c1060ee577f0df8869a4efd5ea033

<details><summary>Show Signature</summary>

pinheadmz's public key is on openpgp.org

</details>

hodlinator approved
hodlinator commented at 8:00 AM on October 15, 2026: contributor

ACK 3f7f845cf51c1060ee577f0df8869a4efd5ea033
fanquake merged this on Oct 15, 2026
fanquake closed this on Oct 15, 2026
frankomosh deleted the branch on Oct 15, 2026

Contributors

Labels

Linked (view graph)

#36135 fuzz: test HTTPRequest state machine in http_request #36174 http: throttle send buffer when client stops draining

fuzz: fix stale comments in http_request #36379

External sites

Reviews