fuzz: fix stale comments in http_request #36379

pull frankomosh wants to merge 1 commits into bitcoin:master from frankomosh:2026-09-fuzz-http-comment-fix changing 1 files +2 −4

frankomosh commented at 8:56 AM on September 29, 2026: contributor

Follow-up to #36135 (review), fixing a false comment flagged in review.

The comment says a completed request is always handed back to a worker. Since #36174 it stays in m_req when the send buffer is over MAX_BODY_SIZE.
DrahtBot added the label Fuzzing on Sep 29, 2026
DrahtBot commented at 8:56 AM on September 29, 2026: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36379.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
in src/test/fuzz/http_request.cpp:129 in 2de494ee5c
```
 125 | @@ -126,7 +126,8 @@ void Drain(const std::shared_ptr<FuzzClient>& client, RunResult& out)
 126 |  
 127 |          if (!req) {
 128 |              if (const HTTPRequest* cur{client->GetRequest()}) {
 129 | -                // Complete is always handed back, never left behind.
 130 | +                // Complete is handed back unless the send buffer is over MAX_BODY_SIZE (see #36174),
```
maflcko commented at 9:06 AM on September 29, 2026:

Not sure about all the raw #id in code comments. Either the pull request context is important, and it should be a full URL, so that it is easily navigable, or it should just be removed or refer to the (other) code itself.

Same above: How is it relevant that ReadBody returned an empty string before 35182? The comments should explain the current code and context and not some irrelevant context or irrelevant history.

frankomosh commented at 9:29 AM on September 29, 2026:

dropping both
frankomosh force-pushed on Sep 29, 2026
DrahtBot added the label CI failed on Sep 29, 2026
frankomosh renamed this:
~~fuzz: correct stale comment about completed requests~~
fuzz: fix stale comments in http_request
on Sep 29, 2026

fuzz: fix stale comments in http_request

A completed request is no longer always handed back to a worker; it stays
in m_req when the send buffer is full.

Also drop the pre-existing comment/note about what ReadBody() returned before the libevent
replacement.

c8bdd7f192

frankomosh force-pushed on Sep 29, 2026
DrahtBot removed the label CI failed on Sep 29, 2026

Contributors

Labels

Linked (view graph)

#36135 fuzz: test HTTPRequest state machine in http_request #36174 http: throttle send buffer when client stops draining

fuzz: fix stale comments in http_request #36379

Code Coverage & Benchmarks

Reviews