The verbose help for sendtoaddress and sendmany paraphrased fee_reason and left out "User Specified Fee". The strings the RPC returns are the ones in StringForFeeReason.
Join that map for both help lines, the same way estimate_mode help is built from FeeModeMap, so the list cannot drift again.
wallet_basic.py checks that an explicit fee_rate returns "User Specified Fee" for sendtoaddress and sendmany.
The verbose help for sendtoaddress and sendmany paraphrased
fee_reason and left out "User Specified Fee". The strings the RPC
returns are the ones in StringForFeeReason.
Join that map for both help lines, the same way estimate_mode help
is built from FeeModeMap, so the list cannot drift again.
wallet_basic.py checks that an explicit fee_rate returns
"User Specified Fee" for sendtoaddress and sendmany.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, ismaelsadeeq, sedited |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
589 | @@ -590,6 +590,11 @@ def run_test(self): 590 | assert_equal(txid_feeReason_one["fee_reason"], "Fallback fee") 591 | txid_feeReason_two = self.nodes[2].sendmany(dummy='', amounts={address: 5}, verbose=True) 592 | assert_equal(txid_feeReason_two["fee_reason"], "Fallback fee") 593 | + self.log.info("Test send* RPCs with an explicit fee_rate") 594 | + txid_feeReason_specified = self.nodes[2].sendtoaddress(address=address, amount=1, fee_rate=5, verbose=True) 595 | + assert_equal(txid_feeReason_specified["fee_reason"], "User Specified Fee") 596 | + txid_feeReason_specified_many = self.nodes[2].sendmany(dummy='', amounts={address: 1}, fee_rate=5, verbose=True)
txid_feeReason_specified_many = self.nodes[2].sendmany(amounts={address: 1}, fee_rate=5, verbose=True)
nit: Is this dummy needed or can it be dropped?
lgtm ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
Code review ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
Thanks for the cleanup.
ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af