doc: fix createwallet positional example, descriptors must be true #36460

pull treib-holdings wants to merge 1 commits into bitcoin:master from treib-holdings:doc-createwallet-example changing 1 files +2 −2
  1. treib-holdings commented at 9:17 PM on October 7, 2026: none

    The createwallet example in doc/JSON-RPC-interface.md passes false as the sixth positional argument descriptors. Since v30.0, legacy wallets can no longer be created, so the example fails as written:

    $ bitcoin-cli -regtest createwallet mywallet false false "" false false true
    error code: -4
    error message:
    descriptors argument must be set to "true"; it is no longer possible to create a legacy wallet.
    

    This changes the argument to true in both the comment and the command. The example still shows positional arguments, including load_on_startup as the seventh, and with the change it creates the wallet without error. Tested with v31.1 on regtest.

    No code or tests are affected, this is a documentation only change.

  2. DrahtBot added the label Docs on Oct 7, 2026
  3. DrahtBot commented at 9:17 PM on October 7, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    Stale ACK pablomartin4btc

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. pablomartin4btc commented at 9:22 PM on October 7, 2026: member

    ACK 58ff194754b368c6f601d426cccecb0dbbf98a3c

  5. doc: fix createwallet positional example, descriptors must be true 566699ed76
  6. treib-holdings force-pushed on Oct 7, 2026
  7. maflcko commented at 5:03 AM on October 8, 2026: member

    not sure why you invalidated the ACK by force pushing. Closing for now.

    Also, This is an illustrative example of the schema and not something a user should copy-paste. It failing is probably a good thing.

    Thanks for your interest in contributing! However, since there are hundreds of pending pull requests, I am closing this to focus review on the others. If you wish to contribute in the future, please focus on creating high-quality, original content that demonstrates a clear understanding of the project's requirements and goals. Also, see the contributing guidelines.

  8. maflcko closed this on Oct 8, 2026

  9. treib-holdings commented at 1:19 PM on October 8, 2026: none

    The force-push was to remove my email from the commit, though the ACK on 58ff194 keeps it linked anyway, so here I am. Sorry for resetting the ACK.

    On the example: every other example in this doc runs without error, so this one should as well. Since v30.0 it fails as written, and setting descriptors to true still shows how positional and named arguments combine.

    Going forward I'll help with review, since that's clearly where the bottleneck is.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-20 03:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me