Looks like the Windows native VS build is taking more than 1h30min on every build: https://github.com/bitcoin/bitcoin/actions/runs/37883274713/job/113667552904
I guess the cache stopped working again?
-
maflcko commented at 8:41 AM on October 9, 2026: member
- maflcko added the label Windows on Oct 9, 2026
- maflcko added the label Tests on Oct 9, 2026
- maflcko added the label CI failed on Oct 9, 2026
- maflcko removed the label CI failed on Oct 9, 2026
-
willcl-ark commented at 9:17 AM on October 9, 2026: member
Taking a look.
I think we are not using enough information to populate the cache key. So we are getting "successful restore" (and consequently no updated saves on master) when actually there are ABI mismatches and packages are being rebuilt.
This commit contributes more information to the cache key, which will solve this I think...
-
maflcko commented at 10:19 AM on October 9, 2026: member
Seems fine, but I wonder if this is worth it to maintain. Would it not be easier to just use the runner image version as the key? E.g for the current image it would be
20260925.250.1. I presume GHA will bump that every week or so, which seems fine to invalidate the cache this often, even if they only update paint.exe or so? Along with the vcpk.json hash, this should be sufficient? -
willcl-ark commented at 2:14 PM on October 10, 2026: member
That appears to be ~ monthly as far as I can see here
Contributors