Without a timeout, the test can hang forever on broken systems. This is fine, but it would be nice if the test instead failed with a nicer error message, indicating the timeout.
test: Add missing timeouts for HTTPConnection #36504
pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2610-test-timeout-rest changing 5 files +7 −7-
maflcko commented at 7:36 AM on October 12, 2026: member
- DrahtBot added the label Tests on Oct 12, 2026
-
DrahtBot commented at 7:36 AM on October 12, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36504
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36504.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36504#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
test: Add missing timeouts for HTTPConnection fad441867c
- maflcko renamed this:
test: Add missing timeout in interface_rest.py
test: Add missing timeouts for HTTPConnection
on Oct 12, 2026 - DrahtBot renamed this:
test: Add missing timeouts for HTTPConnection
test: Add missing timeouts for HTTPConnection
on Oct 12, 2026 - maflcko force-pushed on Oct 12, 2026
- DrahtBot added the label CI failed on Oct 12, 2026
- DrahtBot removed the label CI failed on Oct 12, 2026
-
hebasto commented at 12:17 PM on October 12, 2026: member
Concept ACK.
-
test: make wait_until timing arguments keyword-only fa4308dfbf
-
maflcko commented at 3:11 PM on October 12, 2026: member
Pushed a mostly unrelated small test refactor commit
- fanquake requested review from pinheadmz on Oct 13, 2026
-
mercie-ux commented at 8:20 AM on October 13, 2026: contributor
tACK fa4308dfbf
all tests pass
- DrahtBot requested review from hebasto on Oct 13, 2026
-
pinheadmz commented at 12:49 AM on October 14, 2026: member
As long as we're in here, should we fix this too?
Can either add a timeout factor here or just drop the line entirely.
- hebasto approved
-
hebasto commented at 12:53 AM on October 14, 2026: member
ACK fa4308dfbf3a59f95deac382fa955570f814e8ca, I have reviewed the code and it looks OK.
- pinheadmz approved
-
pinheadmz commented at 1:45 AM on October 14, 2026: member
ACK fa4308dfbf3a59f95deac382fa955570f814e8ca
Reviewed and tested on macos/arm64. Used dnctl/pfctl to intentionally slow loopback traffic and timeout-factor=0.1 to ensure the new timeouts triggered.
<details><summary>Show Signature</summary>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 ACK fa4308dfbf3a59f95deac382fa955570f814e8ca -----BEGIN PGP SIGNATURE----- iQJPBAEBCAA5FiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmrO3jIbFIAAAAAABAAO bWFudTIsMi41KzEuMTIsMCwzAAoJEOfimEtiick66L8P/342bJxmbhxR9Z4CszrV K1kfQ6nVqa44Zl/QjFLzPuFS3EQ8rScjOn8mANALNkNGu0sAhs+FabEL8npyJNgg cWEYJQfwjuCZQFB/UFZJFJsZmfGCGzJdBlxrj2+OjVv7A+IVXs1UP6G21Gux4EQg 7KiX3xZep0Rc2hOorjyI73GP/I0GgzJzZBzxVwEhSHKLOhbp0HJu7mdCcYSQMyhc wPUK16SckS1rna3rVoCmOb9FhnWVkyglypcBy4Kyd9CTsrJGGqTXVJdkQVWmYiXb 6YQtqLX5gRo21FFd4RkO5ddDA3J257cKAxEjDsXJpuQ9PenpVEFTwtyrpYtIelpa 5hlArfRgM6QkVPJ6WdKRYqy3d2pYIjEZ4kAhnIc8YNXtw46hQUSJliS5ZhNV8JMr GopyqOQLSYiuFGVT2inqC6/ohYDXt3rzKzmYZk9P2Kv5LR60qVo3cMAHAOkq4DSu drAb7dWblxg2JgHuRhVQfKzJxb85j9BSWoTCTwX1JaeekZOHDoA/Qj6eHESLa4It oEnSQkvlcyowcM5PUnwuCNjNdTR3xotyEAafUakHw7GS+r3TVher7KDydEhwYBOv 3ywx0KfYyb8K6EXf5o0ZarExRoykO5kmW40VpK3TxqDWu5Vx8UX9YmUTPP2tl1WL dx4/3hXjv6Be1lC5H78u/OCN =kEoD -----END PGP SIGNATURE-----pinheadmz's public key is on openpgp.org
</details>
- fanquake merged this on Oct 14, 2026
- fanquake closed this on Oct 14, 2026
- maflcko deleted the branch on Oct 14, 2026
