test: Small mempool_compatibility.py cleanups #36511

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2610-test-mempool-compat changing 1 files +11 −18
  1. maflcko commented at 8:51 AM on October 13, 2026: member

    After #36294:

    • The MiniWallet mode can be dropped (using the default), now that all nodes support taproot.
    • The sync_fun=self.no_op can be dropped (using the default sync), if the node connection is done earlier.
    • A check for the unbroadcast set can be added, now that all nodes support persisting the set.
  2. DrahtBot added the label Tests on Oct 13, 2026
  3. DrahtBot commented at 8:52 AM on October 13, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK mercie-ux, fjahr

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. test: Small mempool_compatibility.py cleanups fae8a8fd3c
  5. maflcko force-pushed on Oct 13, 2026
  6. DrahtBot added the label CI failed on Oct 13, 2026
  7. DrahtBot commented at 9:02 AM on October 13, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task lint: https://github.com/bitcoin/bitcoin/actions/runs/38372223938/job/115211755213</sub> <sub>LLM reason (✨ experimental): CI failed because Ruff found an unused MiniWalletMode import in test/functional/mempool_compatibility.py.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  8. DrahtBot removed the label CI failed on Oct 13, 2026
  9. mercie-ux commented at 5:50 AM on October 14, 2026: contributor

    tACK fae8a8fd3cc5c511191a18665a731195a9ac228d

    Tested locally against v31.0 (x86_64-linux-gnu), it passes. I also verified the new unbroadcast assertion catches a regression, clearing unbroadcast_txids before it's written in DumpMempool makes the test fail at the new assert_equal (not(False == True)), while the earlier asserts still pass, including both txs being in the old node's mempool.

  10. fjahr commented at 2:03 AM on October 15, 2026: contributor

    Code review ACK fae8a8fd3cc5c511191a18665a731195a9ac228d

  11. fanquake merged this on Oct 15, 2026
  12. fanquake closed this on Oct 15, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-21 18:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me