Fix a pre-existing typo and #36446 (review)
test: Small p2p_node_network_limited.py cleanups #36541
pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2610-test-p2p-limited-cleanup changing 1 files +8 −18-
maflcko commented at 10:15 AM on October 15, 2026: member
-
fa13e8954d
test: Fix block height typos in test logs
NODE_NETWORK_LIMITED_MIN_BLOCKS includes two blocks of buffer, so the "tip-288" and "tip-289" comments were wrong. Also, the first mined block is at height 1, not height 2.
-
fadcd0b64e
test: Remove confusing ensure_for
There is no "trickle delay" for blocks, so a single ping should be sufficient to drain any possible in-flight blocks. Remvoe the ensure_for and directly assert the outcome.
- DrahtBot added the label Tests on Oct 15, 2026
-
DrahtBot commented at 10:15 AM on October 15, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36541
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36541.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36541#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK mercie-ux If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
mercie-ux commented at 11:39 AM on October 16, 2026: contributor
ACK fadcd0b64e
removing
&& !IsLimitedPeer(peer)from the IBD download condition causes theinflightassertion to fail immediately. - fanquake merged this on Oct 19, 2026
- fanquake closed this on Oct 19, 2026
- maflcko deleted the branch on Oct 19, 2026
Labels