Fixes #36533 by waiting for the socket to actually close on the Python side.
A diff to reproduce (with a minimal fix commented out) is in the issue thread.
The fix here rhymes on the minimal fix.
test: Fix intermittent issue in p2p_eviction.py #36544
pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2610-test-int-p2p-evict changing 1 files +5 −4-
maflcko commented at 3:07 PM on October 15, 2026: member
- DrahtBot added the label Tests on Oct 15, 2026
-
DrahtBot commented at 3:07 PM on October 15, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36544
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36544.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36544#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK ViniciusCestarii If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
test: Fix intermittent issue in p2p_eviction.py fa9a965750
- maflcko force-pushed on Oct 15, 2026
- DrahtBot added the label CI failed on Oct 15, 2026
- DrahtBot removed the label CI failed on Oct 15, 2026
-
ViniciusCestarii commented at 10:30 PM on October 15, 2026: contributor
tACK fa9a9657506dc742e657b2a288baed84873304f1
Verified with the repro diff that this prevents the intermitent failure
- fanquake merged this on Oct 16, 2026
- fanquake closed this on Oct 16, 2026
- maflcko deleted the branch on Oct 16, 2026
Contributors
Labels