test: reorder functional tests by current runtimes #36582

pull ViniciusCestarii wants to merge 2 commits into bitcoin:master from ViniciusCestarii:reorder-tests changing 1 files +13 −13
  1. ViniciusCestarii commented at 11:37 AM on October 20, 2026: contributor

    After #36439, #36440 and #36446 some tests got much faster.

    Move tests that finish faster to run later and move tests that are slow to run earlier.

    Timings from master CI run 39389906008:

    Test Bucket (before → after) CI median CI max
    interface_http.py <30s (late) → <60s (first) 53s 60s (TSan)
    feature_maxuploadtarget.py <2m → <30s (first) 10s 44s (Windows native, VS)
    feature_torcontrol.py <30s (late) → <30s (early) 17s 20s (macOS native)
    wallet_conflicts.py <5m → <30s 4s 11s (TSan)
    p2p_node_network_limited.py --v1transport <5m → <30s 6s 18s (TSan)
    p2p_node_network_limited.py --v2transport <5m → <30s 6s 17s (TSan)
    wallet_backup.py <60s → <30s 8s 17s (TSan)
    wallet_address_types.py <60s → <30s 7s 20s (TSan)
    p2p_sendheaders.py <60s → <30s 3s 8s (TSan)
    feature_maxtipage.py <60s → <30s 5s 11s (TSan)
    feature_csv_activation.py <60s → <30s 6s 13s (TSan)
    feature_segwit.py --v1transport <60s → <30s 4s 12s (TSan)
    feature_segwit.py --v2transport <60s → <30s 4s 14s (TSan)

    Locally (test_runner.py -j=18 --randomseed=1) with these changes I got: 84s -> 78s (median of 3 runs)

  2. test: move fast tests to run later 6a59afd317
  3. test: move slow tests to run earlier 649e075655
  4. DrahtBot added the label Tests on Oct 20, 2026
  5. DrahtBot commented at 11:37 AM on October 20, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK maflcko, hebasto
    Concept ACK l0rinc

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. l0rinc commented at 11:50 AM on October 20, 2026: contributor

    Concept ACK - thanks for working on these

  7. maflcko commented at 12:17 PM on October 20, 2026: member

    not sure why feature-maxuploadtarget is moved twice, but this seems fine.

    review ACK 649e075655c653f0581ba7a28f7bda2b347fad80 🦃

    <details><summary>Show signature</summary>

    Signature:

    untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    trusted comment: review ACK 649e075655c653f0581ba7a28f7bda2b347fad80 🦃
    Uqjea51dXxNxPK5aSsa5UfiXYj14s2WdoIyedL7tPMBPmeYPMqtWUxNhu8jUhrag6ua+BVDc7e26GsT07Fy7Dw==
    

    </details>

  8. DrahtBot requested review from l0rinc on Oct 20, 2026
  9. hebasto approved
  10. hebasto commented at 12:34 PM on October 20, 2026: member

    ACK 649e075655c653f0581ba7a28f7bda2b347fad80.

  11. hebasto merged this on Oct 20, 2026
  12. hebasto closed this on Oct 20, 2026

  13. l0rinc commented at 12:41 PM on October 20, 2026: contributor

    post-merge ACK 649e075655c653f0581ba7a28f7bda2b347fad80

    Reapplied the moves in reverse and confirmed they cancelled the diff. I haven’t revalidated the timings, but the ordering looks reasonable given the reported measurements, and I expect we’ll adjust these regularly anyway.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-21 19:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me