test: avoid reusing AssumeUTXO coin insertion method in test fixtures #36601

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/coins-tests-without-snapshot-bypass changing 2 files +10 −6
  1. l0rinc commented at 7:36 AM on October 22, 2026: contributor

    Problem: Several coin-cache fixtures use EmplaceCoinInternalDANGER just to set up their coins, even though it is reserved for snapshot loading.

    Fix: Use AddCoin and SpendCoin for fixture setup, keeping the entries dirty but not fresh, as before. Keep the simulation, fuzz and duplicate-insertion coverage that intentionally tests the bypass.

    This is a small extraction from #36598 that can be reviewed and merged independently of the broader AssumeUTXO removal demo. The overlay fixture change also follows the earlier [suggestion in #35295](https://github.com/bitcoin/bitcoin/pull/35295#discussion_r3421846300).

  2. test: avoid snapshot insertion in coin fixtures
    Use `AddCoin` and `SpendCoin` to set up the flush, reset and overlay tests, leaving direct coverage of `EmplaceCoinInternalDANGER` in the simulation, fuzz target and duplicate-insertion test.
    Set `possible_overwrite=true` to keep the entries DIRTY but not FRESH, as before.
    1c62336903
  3. DrahtBot added the label Tests on Oct 22, 2026
  4. DrahtBot commented at 7:36 AM on October 22, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. DrahtBot added the label CI failed on Oct 22, 2026
  6. DrahtBot commented at 8:34 AM on October 22, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task 32 bit ARM: https://github.com/bitcoin/bitcoin/actions/runs/39741631849/job/119699974970</sub> <sub>LLM reason (✨ experimental): CTest failed because ARM-target test executables could not run on the host and were interpreted as shell scripts, producing syntax errors.</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  7. DrahtBot removed the label CI failed on Oct 22, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-23 11:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me