test: keep noban_tx_relay config after node is restarted #36616

pull ViniciusCestarii wants to merge 1 commits into bitcoin:master from ViniciusCestarii:keep-noban_tx_relay-restart changing 1 files +2 −3

ViniciusCestarii commented at 8:30 PM on October 22, 2026: contributor

When a node restarts with extra_args it loses its original extra_args, so the -whitelist=noban,in,out@127.0.0.1 set by noban_tx_relay is lost and the node falls back to the normal tx relay delays.

This changes noban_tx_relay to set whitelist=noban,in,out@127.0.0.1 in extra_confs instead, so it is kept across restarts.

This speeds up some tests (running locally build/test/functional/test_runner.py -j=18 --randomseed=1):

mempool_ephemeral_dust.py 49s -> 18s mempool_accept_wtxid.py 17s -> 6s wallet_fundrawtransaction.py 11s -> 7s

Accumulated 1152s -> 1110s Wall 80s -> 75s
DrahtBot added the label Tests on Oct 22, 2026
DrahtBot commented at 8:30 PM on October 22, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36616
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36616.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36616#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK maflcko, brunoerg

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
in test/functional/test_framework/test_framework.py:455 in c0ca4beed6
```
 453 | @@ -454,8 +454,7 @@ def bin_dir_from_version(version):
 454 |              extra_args = [[]] * num_nodes
 455 |          # Whitelist peers to speed up tx relay / mempool sync. Don't use it if testing tx relay or timing.
```
maflcko commented at 7:53 AM on October 23, 2026:

nit: There are many different whitelist permissions, so maybe clarify that this is the noban one, and not the mempool or relay one, which are also transaction related?

# Use noban permission to speed up tx relay / mempool sync. Don't use it if testing tx relay or timing.

Ref: NET_PERMISSIONS_DOC
ViniciusCestarii commented at 10:19 AM on October 23, 2026:

Thanks! Done in b469ff8fddb6594b69d564cca436b7baa8ed99bb
maflcko approved
maflcko commented at 7:54 AM on October 23, 2026: member

thx, lgtm. Just a small nit on the comment to be more precise, while touching this block
test: keep noban_tx_relay config after node is restarted b469ff8fdd
ViniciusCestarii force-pushed on Oct 23, 2026
ViniciusCestarii commented at 10:20 AM on October 23, 2026: contributor

Thanks for reviewing. Force-pushed b469ff8fddb6594b69d564cca436b7baa8ed99bb addressing #36616 (review)
maflcko commented at 10:40 AM on October 23, 2026: member

lgtm ACK b469ff8fddb6594b69d564cca436b7baa8ed99bb
brunoerg commented at 11:02 AM on October 23, 2026: contributor

code review ACK b469ff8fddb6594b69d564cca436b7baa8ed99bb

nice!
fanquake merged this on Oct 23, 2026
fanquake closed this on Oct 23, 2026

Type	Reviewers
ACK	maflcko, brunoerg

Contributors

Labels

test: keep noban_tx_relay config after node is restarted #36616

External sites

Reviews