Some descriptor error messages quote the string the caller sent, and a descriptor can hold a private key. The error then carries the key, or part of it, into places the request may not go: an application's log, an error reporter, a screenshot shared for help.
This PR stops the quoting. A failing key is named by its position, a failing entry of solving_data.descriptors by its index, and a function name is quoted only where the parser accepts it. The commit message lists each changed error.
| before | after |
|---|---|
key '<key>' is not valid |
key is not valid |
Multi: key '<key>' is not valid |
Multi: key 3: key is not valid |
'wpkh(<key>)x' is not a valid descriptor function |
Unexpected text after the closing ')' of wpkh() |
'<start of a key>(<rest>' is not a valid descriptor function |
Not a valid descriptor expression |
Unable to parse descriptor '<descriptor>': Missing checksum |
Unable to parse descriptor at index 1: Missing checksum |
Could not add descriptor '<descriptor>': ... |
the same, quoting the public form of the descriptor |