wallet: export replaces_txid and replaced_by_txid #36685

pull vasild wants to merge 1 commits into bitcoin:master from vasild:wallet_replaces_txid changing 2 files +4 −0

vasild commented at 5:23 PM on October 28, 2026: contributor

Export the fields replaces_txid and replaced_by_txid from wallet::CWalletTx to interfaces::WalletTx.

In May 2026 https://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c hooked a usage of interfaces::WalletTx::value_map["replaces_txid"] and interfaces::WalletTx::value_map["replaced_by_txid"] into the QML GUI.

Then, in June 2026 https://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497 removed the map entirely from the main repository, but the replaces_txid and replaced_by_txid fields were not exposed in interfaces::WalletTx. Thus the QML GUI has no access to them.

Export the fields to solve this.

The QT5 GUI never used those.

wallet: export replaces_txid and replaced_by_txid

Export the fields `replaces_txid` and `replaced_by_txid` from
`wallet::CWalletTx` to `interfaces::WalletTx`.

In May 2026
https://github.com/bitcoin-core/gui-qml/commit/f4ff2b8db93cea7ce16c1b914bd4a89393a5810c
hooked a usage of
`interfaces::WalletTx::value_map["replaces_txid"]` and
`interfaces::WalletTx::value_map["replaced_by_txid"]` into the QML GUI.

Then, in June 2026
https://github.com/bitcoin/bitcoin/commit/a2b0bfcd854548820057143f9b5b2213736c5497
removed the map entirely from the main repository, but the
`replaces_txid` and `replaced_by_txid` fields were not exposed in
`interfaces::WalletTx`. Thus the QML GUI has no access to them.

Export the fields to solve this.

The QT5 GUI never used those.

bff0a2fabf

DrahtBot added the label Wallet on Oct 28, 2026
DrahtBot commented at 5:23 PM on October 28, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36685
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36685.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36685#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK pseudoramdom, johnny9

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
vasild commented at 5:25 PM on October 28, 2026: contributor

cc @pseudoramdom, @achow101 @johnny9, @hebasto
vasild commented at 5:34 PM on October 28, 2026: contributor

An update of the bitcoin submodule in https://github.com/bitcoin-core/gui-qml to 631b0065a7f2696a7240db4bbb63589444dc96b8: https://github.com/vasild/gui-qml/commit/f9e392e49753289bb7262771b013761a12694084 it requires the changes in this PR.
pseudoramdom commented at 5:47 PM on October 28, 2026: contributor

Thanks for catching this! The gui-qml is pinned to an older Core version that still exposes value_map. So I hadn't realized these fields had been removed from the interface.

ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0
johnny9 commented at 8:34 PM on October 28, 2026: contributor

ACK bff0a2fabfeceeb739c0d545cb9d45e2a7da43f0

Thanks for catching this. We should update the gui-qml project as soon as this merges.

Type	Reviewers
ACK	pseudoramdom, johnny9

Contributors

Labels

wallet: export replaces_txid and replaced_by_txid #36685

External sites

Reviews