test: wait for the node to finish the last block in p2p_ping_ibd #36687

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:2026-10-ping-ibd-race changing 1 files +3 −0
  1. instagibbs commented at 6:08 PM on October 28, 2026: member

    ProcessBlock() stamps m_last_block_time only after ProcessNewBlock() returns, so getblockcount can show the new height, with nothing in flight, before the stamp is taken. A bumpmocktime in that gap stamps the block with the bumped time, and the final bump then leaves the ping timeout exactly at its boundary, where it never fires. Sync with a ping after the last block, so the node has finished processing it before the clock moves.

    The race has been present since the test was added in #36080.

    Faling job: https://github.com/bitcoin/bitcoin/actions/runs/40589303246/job/122489039018

  2. test: wait for the node to finish the last block in p2p_ping_ibd
    ProcessBlock() stamps m_last_block_time only after ProcessNewBlock() returns, so getblockcount
    can show the new height, with nothing in flight, before the stamp is taken. A bumpmocktime in
    that gap stamps the block with the bumped time, and the final bump then leaves the ping timeout
    exactly at its boundary, where it never fires. Sync with a ping after the last block, so the
    node has finished processing it before the clock moves.
    
    The race has been present since the test was added in #36080.
    9af82f9872
  3. DrahtBot added the label Tests on Oct 28, 2026
  4. DrahtBot commented at 6:08 PM on October 28, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. instagibbs commented at 6:08 PM on October 28, 2026: member

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-29 06:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me