test: Sync blocks in test_witness_block in p2p_segwit.py #36703

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2610-test-fix-sync changing 1 files +87 −91
  1. maflcko commented at 11:46 AM on October 30, 2026: member

    test_witness_block does not sync the blocks across nodes by default, so the test may intermittently fail.

    Fixes #36700 by adding the sync.

  2. test: Sync blocks in test_witness_block in p2p_segwit.py fab8fd026c
  3. DrahtBot added the label Tests on Oct 30, 2026
  4. DrahtBot commented at 11:46 AM on October 30, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK Crypt-iQ

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. hebasto commented at 11:56 AM on October 30, 2026: member
  6. maflcko commented at 11:58 AM on October 30, 2026: member

    Ah, sorry, I forgot the diff to reproduce:

    diff --git a/src/net_processing.cpp b/src/net_processing.cpp
    index c49b2fde40..b3ab04d65f 100644
    --- a/src/net_processing.cpp
    +++ b/src/net_processing.cpp
    @@ -3688,2 +3688,3 @@ void PeerManagerImpl::ProcessBlock(CNode& node, const std::shared_ptr<const CBlo
     {
    +    UninterruptibleSleep(60ms); // Temporary delay to reproduce block relay timing races.
         bool new_block{false};
    
  7. Crypt-iQ commented at 12:56 PM on October 30, 2026: contributor

    crACK fab8fd026cfb24c9f246fb60fbff155f3414bacd

  8. fanquake merged this on Oct 30, 2026
  9. fanquake closed this on Oct 30, 2026

  10. hebasto approved
  11. hebasto commented at 2:05 PM on October 30, 2026: member

    Post-merge ACK fab8fd026cfb24c9f246fb60fbff155f3414bacd.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-30 15:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me