test_witness_block does not sync the blocks across nodes by default, so the test may intermittently fail.
Fixes #36700 by adding the sync.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | Crypt-iQ |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
A CI run on FreeBSD is here: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/41051608081.
Ah, sorry, I forgot the diff to reproduce:
diff --git a/src/net_processing.cpp b/src/net_processing.cpp
index c49b2fde40..b3ab04d65f 100644
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -3688,2 +3688,3 @@ void PeerManagerImpl::ProcessBlock(CNode& node, const std::shared_ptr<const CBlo
{
+ UninterruptibleSleep(60ms); // Temporary delay to reproduce block relay timing races.
bool new_block{false};
crACK fab8fd026cfb24c9f246fb60fbff155f3414bacd
Post-merge ACK fab8fd026cfb24c9f246fb60fbff155f3414bacd.