refactor: Enable bugprone-signed-char-misuse #36715

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2610-bugprone-signed-char-misuse changing 4 files +4 −3
  1. maflcko commented at 7:32 PM on October 30, 2026: member

    This can help to prevent out-of-bounds reads such as the one removed in 43a33e513c4044dc01d92e77da76f2e98faaedb5, or prevent other bugs.

    There is some code that correctly uses signed chars, but this can be trivially made "tidy" by using C++11 narrowing init to int (or whatever type you want).

  2. refactor: Enable bugprone-signed-char-misuse fa6efa5da5
  3. DrahtBot added the label Refactoring on Oct 30, 2026
  4. DrahtBot commented at 7:32 PM on October 30, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK jpk68
    Concept ACK hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. jpk68 commented at 8:00 PM on October 30, 2026: contributor

    ACK fa6efa5da55c4b1acda336fb875e94b020c023a6

  6. hebasto commented at 1:13 PM on October 31, 2026: member

    Concept ACK.

  7. fanquake merged this on Nov 2, 2026
  8. fanquake closed this on Nov 2, 2026

  9. maflcko deleted the branch on Nov 2, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-09 21:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me