cli: use uint16_t for -netinfo block-relay and manual peer counts #36719

pull Snan0M wants to merge 1 commits into bitcoin:master from Snan0M:netinfo-peer-count-width changing 1 files +2 −2

Snan0M commented at 2:36 PM on October 31, 2026: none

These two -netinfo counters are uint8_t while the others are uint16_t, so they wrap at 256 (reachable for manual peers via addnode onetry).

cli: use uint16_t for -netinfo block-relay and manual peer counts

The other -netinfo peer counts are uint16_t, but these two were uint8_t
and wrap at 256. Manual peers aren't limited to the 8 -addnode slots
(addnode onetry connections also count as manual), so the manual count
can reach that and the "manual" column then disappears or shows a
wrapped value.

feeb2fdccf

DrahtBot added the label Scripts and tools on Oct 31, 2026
DrahtBot commented at 2:36 PM on October 31, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36719
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36719.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36719#author-ralph


Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
pinheadmz commented at 2:36 PM on October 31, 2026: member

You just opened 3 PRs really fast. Lets stop there ok? Give us time to digest them

Contributors

Labels

cli: use uint16_t for -netinfo block-relay and manual peer counts #36719

External sites

Reviews