test: check GetTotalBumpFees with a group discount #36728

pull Naomi-Gift wants to merge 1 commits into bitcoin:master from Naomi-Gift:test-total-bump-fees changing 1 files +2 −0
  1. Naomi-Gift commented at 11:13 AM on November 2, 2026: none

    GetTotalBumpFees() in spend.cpp calculates the fee a transaction needs. The mutant adds the group discount instead of subtracting it, making the wallet pay more than necessary.

    The existing test checks the waste score but doesn't verify the actual fee. I added a check that catches this error: with the mutant, it fails with 90 != 30.

    Related: #36614

  2. test: check GetTotalBumpFees with a group discount
    GetTotalBumpFees() is used to compute the fee a transaction needs, but no test checks its value. Check it in bump_fee_test before and after a discount is applied. Kills mutant https://bitcoincore.space/src/wallet/coinselection.cpp#3700
    fc6fcd57bf
  3. DrahtBot added the label Tests on Nov 2, 2026
  4. DrahtBot commented at 11:13 AM on November 2, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 11:30 AM on November 2, 2026: member

    thx, but you'll have to provide the diff of the mutant. Also, the two pulls can be combined into one with two commits?

  6. maflcko closed this on Nov 2, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me