test: check algorithm after SelectionResult::Merge #36614

pull Naomi-Gift wants to merge 1 commits into bitcoin:master from Naomi-Gift:test-selectionresult-merge-algo changing 1 files +23 −0
  1. Naomi-Gift commented at 6:14 PM on October 22, 2026: none

    The wallet merges preset (MANUAL) inputs with the automatic coin selection result in spend.cpp. With the mutant applied, the merged result is incorrectly reported as MANUAL instead of the algorithm that actually selected the coins.

    The test checks both cases:

    • Preset inputs merged into an automatic result should keep the automatic algorithm.
    • A MANUAL result merged with another result should take the algorithm of the other result.

    With the mutant applied, both checks fail with manual != bnb.

  2. test: check algorithm after SelectionResult::Merge 4959d34130
  3. DrahtBot added the label Tests on Oct 22, 2026
  4. DrahtBot commented at 6:14 PM on October 22, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK mercie-ux

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. fanquake commented at 7:30 PM on October 22, 2026: member
  6. mercie-ux commented at 6:14 AM on October 23, 2026: contributor

    ACK 4959d34130

    This covers the surviving mutant https://bitcoincore.space/src/wallet/coinselection.cpp#3707. I ran bcore-mutation and confirmed that merge_algo_test kills it.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-10-29 06:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me