Just a few random sync style-only test-only fixups. See the commit msgs for the rationales.
test: Small test sync fixups #36748
pull maflcko wants to merge 3 commits into bitcoin:master from maflcko:2611-test-cleanups changing 3 files +4 −13-
maflcko commented at 8:52 PM on November 3, 2026: member
-
facf4a0ea9
test: Remove redundant sync_blocks
Both self.generate() and self.test_witness_block(accept=True) sync blocks internally.
-
fa2986921c
test: Use generateblock with submit=False over manual create_block from tmpl
Suggested by L0rinc in https://github.com/bitcoin/bitcoin/pull/35728#discussion_r4441552525
-
fa6f1c00c5
test: Use send_self_transfer_chain
Use the tx-chain helper instead of manual chaining. Suggested by L0rinc in https://github.com/bitcoin/bitcoin/pull/35728#discussion_r4441559708 Also, drop the unused index sync, which happens via the default wait_for_full_init=True when starting the node.
- DrahtBot renamed this:
test: Small test sync fixups
test: Small test sync fixups
on Nov 3, 2026 - DrahtBot added the label Tests on Nov 3, 2026
-
DrahtBot commented at 8:53 PM on November 3, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36748
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36748.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36748#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
