lint: use shared subtree exclusions in shell linters #36749

pull aaron-leeb wants to merge 1 commits into bitcoin:master from aaron-leeb:ci-subtree-lint-scope changing 2 files +10 −7
  1. aaron-leeb commented at 4:18 AM on November 4, 2026: none

    This PR partially addresses the subtree lint scope inconsistencies discussed in #34928.

    The Python shell linters, lint-shell.py and lint-shell-locale.py, now use SHARED_EXCLUDED_SUBTREES instead of maintaining hardcoded subtree exclusions.

    This also removes the overly broad regex in lint-shell.py while preserving the current set of excluded shell scripts.

    The explicit per-linter subtree opt-ins discussed in #34928 are not implemented in this PR. This change focuses on consolidating the existing exclusions without modifying the current lint scope.

    Compared the original exclusion logic against the shared subtree list for all 61 tracked .sh files:

    Linter Before excluded After excluded
    lint-shell.py 10 10
    lint-shell-locale.py 10 10

    Both linters preserve their existing .sh file exclusion scope.

    The following checks also passed:

    • ./ci/lint.py
    • ./ci/lint.py --lint=all_python_linters
    • ./ci/lint.py --lint=py_lint

    Related to #34928.

  2. DrahtBot added the label Tests on Nov 4, 2026
  3. DrahtBot commented at 4:18 AM on November 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. aaron-leeb renamed this:
    ci: use shared subtree exclusions in shell linters
    lint: use shared subtree exclusions in shell linters
    on Nov 4, 2026
  5. lint: use shared subtree exclusions in shell linters c198dc8b96
  6. aaron-leeb force-pushed on Nov 4, 2026
  7. aaron-leeb commented at 4:36 AM on November 4, 2026: none

    Given the direction of #36742, would it make more sense to limit this PR to lint-shell-locale.py and leave the lint-shell.py changes to your PR, @maflcko?

  8. maflcko commented at 8:03 AM on November 4, 2026: member

    thx, but I think it is unclear if this is the right fix. My recommendation would be #34928 (comment), but let's wait a week or two for further input before implementing this.

    Closing this for now in the meantime.

  9. maflcko closed this on Nov 4, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-10 20:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me