lint: shellcheck files with shell shebang #36742

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2611-lint-shellcheck-shebang changing 8 files +39 −44
  1. maflcko commented at 10:53 AM on November 3, 2026: member

    The current shellcheck lint silently ignores all files with a shell shebang that are not ending in .sh.

    Fix it by linting them, which also simplifies the script, because manually appending of guix scripts can be dropped.

    Also, remove global shellcheck exclude of SC2162 (read -r).

  2. lint: shellcheck files with shell shebang fa6b3c4b39
  3. DrahtBot added the label Tests on Nov 3, 2026
  4. DrahtBot commented at 10:54 AM on November 3, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    Concept ACK hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #35686 <sub><img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35686.svg"></sub> (lint: have git-subtree-check check for backportability by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. hebasto commented at 11:19 AM on November 3, 2026: member

    Concept ACK.

  6. lint: Remove global shellcheck exclude of SC2162
    None of the read calls are expected to parse backslash escapes. Use
    `read -r` to preserve literal backslashes if they occur.
    fa439e438c
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-10 20:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me